Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_1fps: init at 0.1.10 #333281

Merged
merged 2 commits into from
Sep 9, 2024
Merged

_1fps: init at 0.1.10 #333281

merged 2 commits into from
Sep 9, 2024

Conversation

renesat
Copy link
Contributor

@renesat renesat commented Aug 8, 2024

Description of changes

Add 1fps client.

Link: https://1fps.video

Code: https://github.com/1fpsvideo/1fps

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@renesat renesat requested a review from alyssais as a code owner August 8, 2024 19:26
@renesat renesat changed the title 1fps: init at 0.1.2 @renesat 1fps: init at 0.1.2 Aug 8, 2024
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Aug 8, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 8, 2024
@renesat renesat changed the title 1fps: init at 0.1.2 1fps: init at 0.1.10 Sep 5, 2024
Aleksanaa
Aleksanaa previously requested changes Sep 8, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name should be _1fps due to a limit of nix language:

nix-repl> 1a = 2
error: syntax error, unexpected '=', expecting end of file
       at «string»:1:4:
            1| 1a = 2
             |    ^

nix-repl> _1a = 2

Also by-name path and commit message.

lib/licenses.nix Outdated Show resolved Hide resolved
pkgs/by-name/1f/1fps/package.nix Outdated Show resolved Hide resolved
@Aleksanaa Aleksanaa changed the title 1fps: init at 0.1.10 _1fps: init at 0.1.10 Sep 8, 2024
@Aleksanaa Aleksanaa mentioned this pull request Sep 8, 2024
Open
@renesat
Copy link
Contributor Author

renesat commented Sep 8, 2024 •
edited
Loading

The package name should be _1fps due to a limit of nix language:

But all work fine with this name nix build .#1fps. One problem. In nix we need to use quotes: "1fps"

The most inconvenient thing is that it won't work in constructions like this:

with pkgs; [
  "1fps"
];

and

inherit "1fps";

But okay, let's do it this way now.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Sep 8, 2024
alyssais
alyssais requested changes Sep 8, 2024
View reviewed changes
pkgs/by-name/_1/_1fps/package.nix Outdated Show resolved Hide resolved
@Aleksanaa Aleksanaa merged commit 59c3aa2 into NixOS:master Sep 9, 2024
25 of 27 checks passed
@willbush willbush mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@alyssais alyssais alyssais approved these changes

Assignees
No one assigned
Labels
6.topic: lib The Nixpkgs function library 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renesat @alyssais @Aleksanaa